Repository navigation
appInfoViewer: Wrap Identifier and Runtime instead of ellipsizing - #895
Malika7188 wants to merge 3 commits into
Conversation
Both fields could get cut off with no way to see the full value, even after resizing the window wider, since the space given to them stays fixed either way. Closes tchx84#792
tchx84
left a comment
tchx84
left a comment
There was a problem hiding this comment.
Hey @Malika7188 , I tested this but, by switching to a GtkBox, it breaks completely the alignment between between fields and values. See image below:
Please check if there's a way to preserve the alignment, or to fix this within the original container.
Both fields could get cut off with no way to see the full value, even after resizing the window wider, since the space given to them stays fixed either way. Keeping the descriptions and the values in two separate containers only worked while every row was one line tall. Move both into a single grid, so each description shares a row with its value and stays with it when the value wraps. Closes tchx84#792
|
Hi @tchx84 , I fixed the alignment. The descriptions and the values were in two separate containers, so I moved them into one grid where each description shares a row with its value. I tested this at different window sizes in English While testing, I also noticed the dates are not formatted correctly in Indonesian when the day is a single digit. See the screenshot below: 
|
This fixed the alignment but introduces a new issue / visual artifact: 
Note that contents of the panel gets occluded when resizing the screen, accompanied with the following warning: This consistently happens in this branch, but doesn't in the original. Can you investigate? |
Both fields could get cut off with no way to see the full value, even after resizing the window wider, since the space given to them stays fixed either way. A wrapped value needs its description to grow along with it, which the two separate containers cannot do. The fix pair each description with its value in a row of its own, and keeps the descriptions a single width with a size group. Closes tchx84#792
Hi @tchx84 , you were right, it came from my change. I had set a minimum width on the wrapping labels, which raised the minimum width of the whole panel. I have fixed that and now pair each description with its value in a row of its own, with a size group keeping the descriptions a consistent width. This removes the need for the minimum width, and the panel now requests the same minimum as master. |
2 participants
The Runtime and Identifier values could get cut off with "…" and stay
that way regardless of window size, since the column they sit in has
a fixed width. Wrapping instead of ellipsizing means the full value is
always visible.
Verified in a real build, in English and in Indonesian (a language
with noticeably longer translated labels), at several window widths
including the single-pane layout.
Closes #792